Author Topic: Engrave frame starts at lower left no matter if set to center or not  (Read 460 times)

tmcgough

  • Newbie
  • *
  • Posts: 2
    • View Profile
In all versions of T2Laser if the settings are set to Center then when displaying trace frame the trace is correct, but then if the user selects engrave frame it will treat the center as the lower left.  Even though center was selected in the configuration.

Steps to reproduce:
1: T2Laser settings - Check the option for Center start point
2: Go into Control Laser...
3: Select  Machine - Trace Frame (Laser Off) - It will trace the outline of the frame
4: Select Machine - Engrave Frame - The laser will turn on in the middle of the Frame and rip its way up to the top as if the middle was actually the bottom left. 

Issue: If trying to cut out a frame after running a job, the laser will ruin the entire project by creating a big cut right up the middle of the just run project.

Engrave frame should honor the setting set for setting center start point.


nottingham82

  • Hero Member
  • *****
  • Posts: 850
    • View Profile
Re: Engrave frame starts at lower left no matter if set to center or not
« Reply #1 on: January 06, 2017, 06:33:15 PM »
hmm sounds like a bug... which version of T2 are you running?
Laser: 2500mw A5 eleks maker
OS: Windows 10 all in one pc
Software: T2
http://www.gearbest.com/3d-printers-3d-printer-kits/pp_290386.html Paid $160 in 2016

Zax

  • T2Laser
  • Global Moderator
  • Hero Member
  • *****
  • Posts: 3825
    • View Profile
    • T2Laser
Re: Engrave frame starts at lower left no matter if set to center or not
« Reply #2 on: January 07, 2017, 05:00:03 AM »
Yes, it should.

I took a look at the code, and sure enough it's a bug. Sorry  :-[

It's an easy fix, as you said the code was already correct when the laser is off and actually using the shortcut (right clicking the laser on icon) was also correct. I had just missed a section of code when implementing the corner start options that caused the menu to function incorrectly.

I've released v1.3u with the fix, see update thread below:

http://benboxlaser.us/index.php/topic,113.msg1263.html#msg1263

fixxxer

  • Newbie
  • *
  • Posts: 5
    • View Profile
Re: Engrave frame starts at lower left no matter if set to center or not
« Reply #3 on: January 07, 2017, 03:49:47 PM »
I have updated to the v1.3u but still has a bug with frame. When I make a text in sketch and I put center position, the text is engraved in the middle and when I select engrave frame, the frame is way bigger than the text.

nottingham82

  • Hero Member
  • *****
  • Posts: 850
    • View Profile
Re: Engrave frame starts at lower left no matter if set to center or not
« Reply #4 on: January 07, 2017, 03:54:58 PM »
Is the frame by chance the same size as what you said your sketch was... Ie A3 or a5?
Laser: 2500mw A5 eleks maker
OS: Windows 10 all in one pc
Software: T2
http://www.gearbest.com/3d-printers-3d-printer-kits/pp_290386.html Paid $160 in 2016

Zax

  • T2Laser
  • Global Moderator
  • Hero Member
  • *****
  • Posts: 3825
    • View Profile
    • T2Laser
Re: Engrave frame starts at lower left no matter if set to center or not
« Reply #5 on: January 07, 2017, 04:01:33 PM »
Do you have Center Absolute selected?

If so, it will use the entire Sketch canvas size.

(nottingham82 beat me to it)

fixxxer

  • Newbie
  • *
  • Posts: 5
    • View Profile
Re: Engrave frame starts at lower left no matter if set to center or not
« Reply #6 on: January 07, 2017, 04:06:09 PM »
No, it has the same width but 10 times the height. No it is not selected Center Absolute.

Zax

  • T2Laser
  • Global Moderator
  • Hero Member
  • *****
  • Posts: 3825
    • View Profile
    • T2Laser
Re: Engrave frame starts at lower left no matter if set to center or not
« Reply #7 on: January 07, 2017, 04:08:51 PM »
I am not seeing that, can you upload the Sketch file so I can check it.

fixxxer

  • Newbie
  • *
  • Posts: 5
    • View Profile
Re: Engrave frame starts at lower left no matter if set to center or not
« Reply #8 on: January 07, 2017, 04:12:36 PM »
It's a test sketch... Wanted to see if the bug is fixed.
« Last Edit: January 07, 2017, 04:13:50 PM by fixxxer »

Zax

  • T2Laser
  • Global Moderator
  • Hero Member
  • *****
  • Posts: 3825
    • View Profile
    • T2Laser
Re: Engrave frame starts at lower left no matter if set to center or not
« Reply #9 on: January 07, 2017, 04:26:10 PM »
I think it's just your interpretation of what the frame should do in this case.

If you select Absolute it's simple, it will use the center of the canvas and draw the frame around the perimeter.

Without Absolute selected I calculate the center point based on the extents of the Sketch, and then the frame is calculated using the 0,0 so in this case the center is X42 Y106 so the frame would be from 0,0 to 84,212.

The reason it's so large in the Y axis is you placed the text half way up the canvas.

I could take extents of the Sketch and use those for the corners, and not use 0,0 at all. If others agree that is a preferred method I will change the logic.

fixxxer

  • Newbie
  • *
  • Posts: 5
    • View Profile
Re: Engrave frame starts at lower left no matter if set to center or not
« Reply #10 on: January 07, 2017, 04:40:01 PM »
I moved the text to Y axis 0,0 and the frame is OK now. Sorry, my mistake. Thank you very much for your prompt reply!

Zax

  • T2Laser
  • Global Moderator
  • Hero Member
  • *****
  • Posts: 3825
    • View Profile
    • T2Laser
Re: Engrave frame starts at lower left no matter if set to center or not
« Reply #11 on: January 07, 2017, 05:02:52 PM »
No mistake, you made me think about my method and I'm not sure it makes sense.

I may change it to use the extents so the frame would be tight around the drawing regardless of where you place it on the canvas.


nottingham82

  • Hero Member
  • *****
  • Posts: 850
    • View Profile
Re: Engrave frame starts at lower left no matter if set to center or not
« Reply #12 on: January 07, 2017, 06:57:19 PM »
so if is wanted to cut a c in the lower left corner of a square piece of work and draw a perimeter around the entire square piece i would need to select absolute.  If I want a c and the frame nice and tight on the letter i need to select center start point with no absolute?  That seems to make sense and would give you 2 different results.  If you change the logic you will get the same result no mater how you sketch it.  That may eliminate the ability to have things off center if that is the desired result.
Laser: 2500mw A5 eleks maker
OS: Windows 10 all in one pc
Software: T2
http://www.gearbest.com/3d-printers-3d-printer-kits/pp_290386.html Paid $160 in 2016

Zax

  • T2Laser
  • Global Moderator
  • Hero Member
  • *****
  • Posts: 3825
    • View Profile
    • T2Laser
Re: Engrave frame starts at lower left no matter if set to center or not
« Reply #13 on: January 08, 2017, 05:08:58 AM »
Yes. That is exactly my logic, which doesn't always make sense to others, so you must be "weird" too  ;)

I always Sketch or design in CAD with the origin in mind, so this has never been a problem but I've also learned that some people don't and use the center of the page, in which case changing the method would be better.

nottingham82

  • Hero Member
  • *****
  • Posts: 850
    • View Profile
Re: Engrave frame starts at lower left no matter if set to center or not
« Reply #14 on: January 08, 2017, 09:40:57 AM »
I guess it makes sense to me because I do both! So I always do a trace before hand.  Some projects I need one thing and other projects I need another.  Often I us a scrap piece the same size as my work piece to be sure I did all the centering or zeroing right.

Of course most of my mistakes are when I measure right and forget to tell T2 that im doing a different start position!  Gotta keep T2 in the loop!
« Last Edit: January 08, 2017, 09:41:59 AM by nottingham82 »
Laser: 2500mw A5 eleks maker
OS: Windows 10 all in one pc
Software: T2
http://www.gearbest.com/3d-printers-3d-printer-kits/pp_290386.html Paid $160 in 2016